Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fluentd-gcp monitoring to use metrics exposed by SD plugin #48812

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Change fluentd-gcp monitoring to use metrics exposed by SD plugin #48812

merged 1 commit into from
Jul 14, 2017

Conversation

crassirostris
Copy link

Following GoogleCloudPlatform/fluent-plugin-google-cloud#135, make fluentd-gcp expose metrics in Prometheus registry and use them instead of counting records in the pipeline.

/cc @piosz @igorpeshansky

Fluentd-gcp DaemonSet exposes different set of metrics.

@crassirostris crassirostris added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Jul 12, 2017
@crassirostris crassirostris added this to the v1.8 milestone Jul 12, 2017
@k8s-ci-robot
Copy link
Contributor

@crassirostris: GitHub didn't allow me to request PR reviews from the following users: igorpeshansky.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

Following GoogleCloudPlatform/fluent-plugin-google-cloud#135, make fluentd-gcp expose metrics in Prometheus registry and use them instead of counting records in the pipeline.

/cc @piosz @igorpeshansky

Fluentd-gcp DaemonSet exposes different set of metrics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from piosz July 12, 2017 15:05
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 12, 2017
igorpeshansky
igorpeshansky approved these changes Jul 12, 2017
View reviewed changes
Copy link

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@piosz
Copy link
Member

piosz commented Jul 13, 2017

/lgtm
/approve
I assume @igorpeshansky reviewed the configuration in depth.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2017
@piosz
Copy link
Member

piosz commented Jul 13, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, piosz

Associated issue requirement bypassed by: piosz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2017
@igorpeshansky
Copy link

@piosz Yes, I've reviewed the configs.

@piosz
Copy link
Member

piosz commented Jul 13, 2017

@igorpeshansky thx!

@crassirostris
Copy link
Author

/test pull-kubernetes-federation-e2e-gce

@crassirostris
Copy link
Author

/retest

2 similar comments
@crassirostris
Copy link
Author

/retest

@crassirostris
Copy link
Author

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 48812, 48276)

@k8s-github-robot k8s-github-robot merged commit 455e44b into kubernetes:master Jul 14, 2017
@k8s-ci-robot
Copy link
Contributor

@crassirostris: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e 125f759 link /test pull-kubernetes-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crassirostris crassirostris mentioned this pull request Jul 24, 2017
Merged
@wojtek-t wojtek-t modified the milestones: v1.7, v1.8 Jul 26, 2017
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 26, 2017
k8s-github-robot pushed a commit that referenced this pull request Jul 26, 2017
Merge pull request #49490 from crassirostris/automated-cherry-pick-of…
cb9a292 
…-#48812-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #48812

Cherry pick of #48812 on release-1.7.

#48812: Change fluentd-gcp monitoring to use metrics exposed by SD

```release-note
Fluentd-gcp DaemonSet exposes different set of metrics
```
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

@piosz piosz Awaiting requested review from piosz

Assignees

@piosz piosz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@crassirostris @k8s-ci-robot @piosz @k8s-github-robot @igorpeshansky @k8s-cherrypick-bot @wojtek-t